Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authenticate: fix debug and metrics endpoints #3212

Merged
merged 1 commit into from Mar 30, 2022

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Mar 29, 2022

Summary

Fix the debug and metrics endpoints so they appear on a different listener.

Related issues

Fixes https://github.com/pomerium/internal/issues/816

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added bug Something isn't working backport 0-17-0 labels Mar 29, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner March 29, 2022 21:17
@calebdoxsey calebdoxsey requested a review from wasaga March 29, 2022 21:17
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 64.596% when pulling f7d9051 on cdoxsey/internal-listeners into 5fc9e68 on main.

Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

routes = append(routes, r)
routes = append(routes,
// enable ext_authz
b.buildControlPlanePathRoute("/.pomerium/jwt", true),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typed bools would be great here for readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-17-0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants