Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httputil/reproxy: fix policy transport #3322

Merged
merged 1 commit into from May 5, 2022
Merged

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented May 3, 2022

Summary

Fix the reproxy policy transport so that it disables the custom TLS dialer. When the custom TLS dialer is set transport.TLSClientConfig is ignored.

Related issues

Fixes #3321

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added bug Something isn't working backport 0-17-0 labels May 3, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner May 3, 2022 18:33
@calebdoxsey calebdoxsey requested a review from wasaga May 3, 2022 18:33
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 64.32% when pulling 567b8f1 on cdoxsey/policy-transport into 90b7c1d on main.

@calebdoxsey calebdoxsey merged commit 6b663ba into main May 5, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/policy-transport branch May 5, 2022 00:32
backport-actions-token bot pushed a commit that referenced this pull request May 5, 2022
calebdoxsey added a commit that referenced this pull request May 5, 2022
(cherry picked from commit 6b663ba)

Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-17-0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route/policy options tls_custom_ca and tls_skip_verify not working in 0.17.2
3 participants