New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4.0dev Agent REST Call doesn't return unassociated agents. #103

Closed
dsully opened this Issue Oct 4, 2011 · 6 comments

Comments

Projects
None yet
2 participants
@dsully

dsully commented Oct 4, 2011

When calling: GET /-/agents

I would expect to see a map of both agents assigned to a fabric, and those that are not yet assigned.

Looking at the Web UI code, this is done via:

def missingAgents = systemService.getMissingAgents(request.fabric)

But, with the above REST call, there is no fabric.

rest_list_agents_fabrics() needs to return the missingAgents as well, without having a Fabric selected.

Thanks

@ypujante

This comment has been minimized.

Member

ypujante commented Oct 5, 2011

I will look into it. I also think there is an issue with this call because agent names are not necessarily unique across fabrics so returning a map of agent-name -> fabric may not always work.

@dsully

This comment has been minimized.

dsully commented Oct 5, 2011

Should the map be reversed then, to account for that potential (but rare) case?

{
"fabric1" => [ "agent1", "agent2" ],
"fabric2" => [ "agent1" ],
"Unassigned" => [ "agent3 "],
}

@ypujante

This comment has been minimized.

Member

ypujante commented Oct 5, 2011

Probably. I think I want to use "-" instead of "Unassigned" since it is
already somewhat reserved.

On Wed, Oct 5, 2011 at 6:48 AM, Dan Sully <
reply@reply.github.com>wrote:

Should the map be reversed then, to account for that potential (but rare)
case?

{
"fabric1" => [ "agent1", "agent2" ],
"fabric2" => [ "agent1" ],
"Unassigned" => [ "agent3 "],
}

Reply to this email directly or view it on GitHub:
https://github.com/linkedin/glu/issues/103#issuecomment-2298044

@dsully

This comment has been minimized.

dsully commented Oct 5, 2011

Works for me.

@dsully

This comment has been minimized.

dsully commented Oct 7, 2011

Works great! Ship it!

@ypujante

This comment has been minimized.

Member

ypujante commented Oct 12, 2011

fixed with 3.4.0

@ypujante ypujante closed this Oct 12, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment