New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELTA takes priority over ERROR in the UI #116

Closed
elutfall opened this Issue Jan 24, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@elutfall

elutfall commented Jan 24, 2012

In recent versions - not sure when it started - if you have a mountpoint that is in error (not deployed, not running, etc) and it has a delta, the line gets colored yellow.

This is not good, as we lose the view of if an app is actually down or just waiting for its delta to be resolved. We may have an app staged for deployment hours before it actually deploys, but we still want to know that it's running up until we do the deploy.

I thought this worked in the first version that introduced the different color for DELTA, I only now noticed the change.

@ypujante

This comment has been minimized.

Member

ypujante commented Jan 24, 2012

are you saying that in this case it should be red for error? Does that mean that only when it is running should the color be yellow? otherwise it should be red?

@elutfall

This comment has been minimized.

elutfall commented Jan 25, 2012

That's what we think, yes. We need to be able to see if an app is up or down first and foremost. So if 20 apps have a delta, but 3 of them are down, we should see that those 3 are red because they are in a non-running state and may need attention. Otherwise, the delta masks the fact that they are not running.

In our environment, changes are made to the fabric in the morning for overnight deploys. The deltas show in the console during the time between changing the model and deployment. If an app dies during this window, the console doesn't really tell us much. We have monitoring in place in production, but in other environments the console is what most people use to tell if an app is running or not.

Running no delta - green
Running with a delta - yellow
Stopped with no delta - red
Stopped with a delta - red (status shows delta)
Not Deployed/Should Not Be Deployed - red

This, of course, is just how we feel it should work. I know that we can get the details we need by querying the console, but I don't think we want to create a custom UI for displaying the true status of apps right now.

@ypujante

This comment has been minimized.

Member

ypujante commented Jan 25, 2012

It does make sense and I thought it was the way I implemented it. Let me take a look.

@ypujante

This comment has been minimized.

Member

ypujante commented Jan 25, 2012

Ironically the code is already there: https://github.com/linkedin/glu/blob/master/orchestration/org.linkedin.glu.orchestration-engine/src/main/groovy/org/linkedin/glu/orchestration/engine/delta/DeltaServiceImpl.groovy#L196

The only catch is that the "notRunningOverridesVersionMismatch" variable is not 'exposed' as a configurable property... So the 'fix' is to expose it as a configurable property (and probably change the default to since I believe that is what makes the most sense!)

@elutfall

This comment has been minimized.

elutfall commented Jan 25, 2012

Thanks. We look forward to seeing it in the next version.

@ypujante

This comment has been minimized.

Member

ypujante commented Jan 27, 2012

fixed with 4.1.1

@ypujante ypujante closed this Jan 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment