New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta engine reports success when agents are missing #182

Closed
sodul opened this Issue Nov 15, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@sodul
Contributor

sodul commented Nov 15, 2012

We have a Jenkins job that create machines in AWS every morning (and shut them down at night for cost efficiency), then deploys fresh builds through Glu.

The problem is that puppet failed us (once more) and the agents never got started. Our scripts did generate the proper new model for all the agents on the fabric, then the console-cli send the 'deploy' command to the console. What we got in return is a false success, since no agent was reachable, the delta engine probably concluded that there was nothing to do, with a smile.

From the console-cli output in our Jenkins driven job:
10:39:18 GLU Console message: no plan created (only pending transitions)
10:39:18 Finished: SUCCESS

From the audit log:
11/15/12 10:35:01 PST jenkins system.change fabric: stage, systemId: 9946bafada7665dc0cff33d233dcc918185df818

@liebman

This comment has been minimized.

liebman commented Nov 15, 2012

For contrast - I would not want all deployments to fail because one of 2000 agents was missing....

@sodul

This comment has been minimized.

Contributor

sodul commented Nov 16, 2012

Well if one out of 2000 fails to configure the deployment will be marked as failed. So failing because one agent is missing would be consistent with everything else in my opinion.

Sent from my iPhone

On Nov 15, 2012, at 12:17, liebman notifications@github.com wrote:

For contrast - I would not want all deployments to fail because one of 2000 agents was missing....


Reply to this email directly or view it on GitHub.

@ypujante

This comment has been minimized.

Member

ypujante commented Nov 18, 2012

Unclear if a bug or a feature (marking as both...) :) Will investigate further...

@ypujante

This comment has been minimized.

Member

ypujante commented Dec 21, 2012

Fixed with 4.6.1

@ypujante ypujante closed this Dec 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment