New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support to Users for Default Fabric #211

Closed
aelent opened this Issue Mar 25, 2013 · 7 comments

Comments

Projects
None yet
3 participants
@aelent

aelent commented Mar 25, 2013

It would be nice to have an associated fabric on a user level. We have many fabrics and many users. It is too easy to land on a fabric that shouldn't be touched by user X.

If the above doesn't make sense perhaps a scenario:

2 fabris = fabric1 and fabric2
2 users = user1 and user2

user1 logs in and lands on fabric1
user2 logs in and lands on fabric1
user2 redeploys fabric1 by accident

Would be nice to associate fabric2 with user2

@itshanney

This comment has been minimized.

itshanney commented Mar 25, 2013

This is definitely a nice feature, but it's possibly not the right way Glu is intended to be used. Glu is intended to be used at the lowest level of application deployment. The scenarios you are mentioning should be handled by an application that sits at a higher level than Glu and hands Models (the instructions) off to Glu to accomplish work.

This new application more than likely may not be included in Glu but would be a separate application by itself and would blossom into its own open source project.

@ypujante

This comment has been minimized.

Member

ypujante commented Mar 25, 2013

Here are a couple of points:

  • glu remembers your fabric from login to login (uses a cookie) so once a given user selects the appropriate fabric, he should not have to change it (if it is not working this way, then it is indeed a bug)
  • if you want to allow/disallow deployment on a per user/fabric basis, then write a plugin... the mechanism is already in place to allow you to do this! http://linkedin.github.com/glu/docs/latest/html/orchestration-engine.html#plugins and you can use the DeploymentService_pre_executeDeploymentPlan plugin
@aelent

This comment has been minimized.

aelent commented Mar 26, 2013

Thanks for the prompt response guys.

Yan,
I think the first bullet point you are describing is indeed what we are not experiencing. We are running v4.5.1 of glu-console. Not sure if that was possibly fixed in a more recent version although I did not see it in latest changes.

Steps to be explicit:

  1. Login
  2. Click on Fabric 'foo'
  3. Jetty times out
  4. Login again
  5. Land on Fabric 'bar'

Expected:
Land on Fabric 'foo'

Make sense?

@ypujante

This comment has been minimized.

Member

ypujante commented Mar 26, 2013

Can you check which cookies you have?

@aelent

This comment has been minimized.

aelent commented Mar 26, 2013

[{
"domain": "10.32.2.91",
"hostOnly": true,
"httpOnly": false,
"name": "JSESSIONID",
"path": "/console",
"secure": false,
"session": true,
"storeId": "0",
"value": "16qns7f0skc36astqn0iuupq9"
},
{
"domain": "10.32.2.91",
"expirationDate": 1395857616.908988,
"hostOnly": true,
"httpOnly": false,
"name": "fabric",
"path": "/console",
"secure": false,
"session": false,
"storeId": "0",
"value": "O-KJ_2Bg7-"
},
{
"domain": "10.32.2.91",
"expirationDate": 1395857616.909064,
"hostOnly": true,
"httpOnly": false,
"name": "ucdd",
"path": "/console",
"secure": false,
"session": false,
"storeId": "0",
"value": "UWDLj1sngBbBde-"
}]

@ypujante

This comment has been minimized.

Member

ypujante commented Mar 26, 2013

You do have a "fabric" cookie. I am tagging this ticket as a bug and will look into it.

ypujante added a commit that referenced this issue Apr 17, 2013

@ypujante

This comment has been minimized.

Member

ypujante commented Apr 22, 2013

fixed in glu 4.7.1

@ypujante ypujante closed this Apr 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment