New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpexted exception can disable the agent #27

Closed
andrask opened this Issue Feb 23, 2011 · 2 comments

Comments

Projects
None yet
2 participants
@andrask
Contributor

andrask commented Feb 23, 2011

If a script raises an unexpected exception, the agent's executor thread will crash and the agent becomes unreachable through the CLI (and probably the REST interface too). (Internal error 500 is returned from here on)

Example:
def install = {
log.info "Listing parameters"
args.each { i -> log.info "Parameter ${i} ${i.value} " }
log.info "Install (${params.message})"
}

This results in IllegalMonitorStateException at the args.each line. It works only if install is defined as
def install = { args ->

The main issue is that any unexpected exception may cause the agent to stop operating.

@ypujante

This comment has been minimized.

Member

ypujante commented Feb 23, 2011

This is really bad behavior and I will address very soon. Thanks for reporting.

@ypujante

This comment has been minimized.

Member

ypujante commented Mar 1, 2011

Fixed with 2.1.0. It turned out to be a pretty nasty issue. Thanks for reporting!

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment