New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fetch full json model on System page #77

Closed
ypujante opened this Issue Jul 19, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@ypujante
Member

ypujante commented Jul 19, 2011

The System page can become heavy to load as more and more systems are loaded especially if the systems are big. The value on this page is not very useful so remove fetching the full model on this page to make it much more lightweight.

@li-mdubey

This comment has been minimized.

Contributor

li-mdubey commented Jul 19, 2011

This would be pretty nice. We (Dan) simplified our System panel to only show date, fabric and systemId in the list view. Details screen still shows the whole model.

Other change was to make model text area readonly. Large models (5MB) in our case, cannot be saved, as they hit various upload limits (form POST limits) on tomcat and grails side.

@ghost ghost assigned ypujante Sep 13, 2011

ypujante added a commit that referenced this issue Sep 16, 2011

#77: optimize system list page
 - add size column to DbSystemModel (nullable for db upgrade)
 - no longer fetch the 'content' and use the size column (if available)

@ypujante ypujante closed this Sep 16, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment