New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nesting /console/ in a sub url in console-cli.py and PEP-8 Python style compliance #193

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@sodul
Contributor

sodul commented Dec 18, 2012

Replaces pull requests 176 and 179

@ypujante

This comment has been minimized.

Member

ypujante commented Dec 21, 2012

Merged in 4.6.1

@ypujante ypujante closed this Dec 21, 2012

@ypujante

This comment has been minimized.

Member

ypujante commented Mar 20, 2013

Hi Stephane.

Debug is not working anymore :(

Traceback (most recent call last):
  File "./bin/console-cli.py", line 280, in <module>
    sys.exit(main())
  File "./bin/console-cli.py", line 178, in main
    gluconsole.rest.log.setLevel(logging.DEBUG)
AttributeError: 'module' object has no attribute 'log'

Could you take a look?

Thanks
Yan

@ypujante ypujante reopened this Mar 20, 2013

@sodul

This comment has been minimized.

Contributor

sodul commented Mar 21, 2013

Will do!

Sent from my iPhone

On Mar 20, 2013, at 2:13 PM, Yan Pujante notifications@github.com wrote:

Hi Stephane.

Debug is not working anymore :(

Traceback (most recent call last):
File "./bin/console-cli.py", line 280, in
sys.exit(main())
File "./bin/console-cli.py", line 178, in main
gluconsole.rest.log.setLevel(logging.DEBUG)
AttributeError: 'module' object has no attribute 'log'
Could you take a look?

Thanks
Yan


Reply to this email directly or view it on GitHub.

@ypujante

This comment has been minimized.

Member

ypujante commented Mar 21, 2013

I found the culprit and fixed it...

diff --git a/console/org.linkedin.glu.console-cli/src/cmdline/resources/bin/console-cli.py b/console/org.linkedin.glu.console-cli/src/cmdline/resources/bin/console-cli.py
index f744970..4b708f5 100755
--- a/console/org.linkedin.glu.console-cli/src/cmdline/resources/bin/console-cli.py
+++ b/console/org.linkedin.glu.console-cli/src/cmdline/resources/bin/console-cli.py
@@ -175,7 +175,7 @@ def main():

     if options.debug:
         log.setLevel(logging.DEBUG)
-        gluconsole.rest.log.setLevel(logging.DEBUG)
+        gluconsole.rest.logger.setLevel(logging.DEBUG)

     if options.filter and options.filter_filename:
         parser.error('Only --systemFilter or --systemFilterFile must be'
@ypujante

This comment has been minimized.

Member

ypujante commented Apr 3, 2013

Fixed with glu 4.7.0

@ypujante ypujante closed this Apr 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment