New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly account for foreign objects in GC #1842

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
4 participants
@dipinhora
Contributor

dipinhora commented Apr 17, 2017

Prior to this commit, foreign objects were accounted for upon
receive but then their impact on the heap was lost whenever GC
ran. This commit resolves that by making sure that foreign objects
are properly accounted in the heap during the marking phase of GC
in a manner similar to how they're accounted for upon receive.

Resolves #1550

Properly account for foreign objects in GC
Prior to this commit, foreign objects were accounted for upon
receive but then their impact on the heap was lost whenever GC
ran. This commit resolves that by making sure that foreign objects
are properly accounted in the heap during the marking phase of GC
in a manner similar to how they're accounted for upon receive.

Resolves #1550
@SeanTAllen

This comment has been minimized.

Member

SeanTAllen commented Apr 18, 2017

@sylvanc can you verify this is as you intended?

@jemc

This comment has been minimized.

Member

jemc commented Apr 18, 2017

Is it possible this also solves #1781?

@dipinhora

This comment has been minimized.

Contributor

dipinhora commented Apr 18, 2017

Upon a quick look, I'm not sure that this change would solve issue #1781. It would need to be tested explicitly to confirm.

@albertnetymk

This comment has been minimized.

albertnetymk commented Apr 18, 2017

My understanding of this PR is that it fixes the heuristics for when to trigger GC, so it probably doesn't fix #1781.

@SeanTAllen SeanTAllen merged commit 6de742b into ponylang:master Apr 19, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

SeanTAllen added a commit that referenced this pull request Apr 19, 2017

Add CHANGELOG for #1842
Missed during merge

@SeanTAllen SeanTAllen referenced this pull request Apr 19, 2017

Closed

Release 0.13.1 #1848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment