New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused FormatSettings interface and related types. #2397

Merged
merged 1 commit into from Dec 3, 2017

Conversation

Projects
None yet
2 participants
@jemc
Member

jemc commented Dec 2, 2017

This interface was from the old Stringable API, which was removed in
#1286

There's no reason to keep this around anymore, as the new Format API
accepts an argument list instead of a FormatSettings object. I think
this interface should have been removed in that PR, but was overlooked.

This commit also reorganizes the other types from the same file,
so that they are better namespaced in keeping with the file naming
convention of the standard library.

Remove unused FormatSettings interface and related types.
This interface was from the old Stringable API, which was removed in
#1286

There's no reason to keep this around anymore, as the new Format API
accepts an argument list instead of a FormatSettings object. I think
this interface should have been removed in that PR, but was overlooked.

This commit also reorganizes the other types from the same file,
so that they are better namespaced in keeping with the file naming
convention of the standard library.

@jemc jemc self-assigned this Dec 2, 2017

@Theodus

Theodus approved these changes Dec 3, 2017

@Theodus Theodus merged commit f51d781 into master Dec 3, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

ponylang-main added a commit that referenced this pull request Dec 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment