Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen ordering of implicit finalisers #2419

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
3 participants
@Praetonus
Copy link
Member

commented Dec 15, 2017

This change ensures that all implicit finalisers are correctly registered before generating user functions. This ensures that every type with an implicit finaliser is correctly recognised as such when generating object allocations.

This doesn't contain a test case because the bug occurs because of the non-deterministic iteration of the reachability map.

Fix codegen ordering of implicit finalisers
This change ensures that all implicit finalisers are correctly
registered before generating user functions. This ensures that every
type with an implicit finaliser is correctly recognised as such when
generating object allocations.

This doesn't contain a test case because the bug occurs because of the
non-deterministic iteration of the reachability map.
@jemc

jemc approved these changes Dec 15, 2017

@SeanTAllen SeanTAllen merged commit b8fe54d into ponylang:master Dec 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ponylang-main added a commit that referenced this pull request Dec 15, 2017

@Praetonus Praetonus deleted the Praetonus:fix-implicit-finalisers branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.