Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep and retry when secondary rate limit impacts on PR search #38

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

SeanTAllen
Copy link
Member

We hit this error semi-regularly. GitHub's secondary rate limiting is easy to trigger. It often will happen if multiple requests to the API are made at the same time from different jobs resulting in a failure. The failure is easy to fix by rerunning the job, but a user has to notice.

There might be other places that we can hit a similar issue, but this commit addresses the known location.

Fixes #37

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 9, 2023
@SeanTAllen SeanTAllen added changelog - added Automatically add "Added" CHANGELOG entry on merge and removed discuss during sync Should be discussed during an upcoming sync labels Feb 9, 2023
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 38.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 9, 2023
We hit this error semi-regularly. GitHub's secondary rate limiting
is easy to trigger. It often will happen if multiple requests to
the API are made at the same time from different jobs resulting in
a failure. The failure is easy to fix by rerunning the job, but a
user has to notice.

There might be other places that we can hit a similar issue, but
this commit addresses the known location.

Fixes #37
@SeanTAllen SeanTAllen merged commit 88ee0e3 into main Feb 9, 2023
@SeanTAllen SeanTAllen deleted the issue-37 branch February 9, 2023 22:10
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 9, 2023
github-actions bot pushed a commit that referenced this pull request Feb 9, 2023
github-actions bot pushed a commit that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle secondary rate limit failures with a pause and retry
2 participants