Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "with-libressl" image to build from source #10

Closed
SeanTAllen opened this issue Jul 5, 2020 · 0 comments · Fixed by #13
Closed

Update "with-libressl" image to build from source #10

SeanTAllen opened this issue Jul 5, 2020 · 0 comments · Fixed by #13
Assignees
@SeanTAllen
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SeanTAllen
Copy link
Member

There are two problems with using the alpine package:

  • The version can change out from underneath us
  • It doesn't necessarily have all the algos we need to test against turned on.

For CI purposes, we should be building from source so that all the algos we need are guaranteed to be on.

We should be using a multistage build for this and copying the built library over into the image. To verify that the image is good when we set up the dockerfiles, we should manually do a ponylang/crypto clone and make test run to verify it all works as expected.
@SeanTAllen SeanTAllen added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 5, 2020
@SeanTAllen SeanTAllen mentioned this issue Jul 5, 2020
Closed
@SeanTAllen SeanTAllen self-assigned this Aug 15, 2020
SeanTAllen added a commit that referenced this issue Aug 15, 2020
@SeanTAllen
Add new libressl testing environment
b73da69 
Our other libressl environment uses whatever version of libressl that
alpine's package manager installs. This new environment is tied to a
specific version of libressl that we build from source.

This gives us more control over what is tested and when we change
what is tested.

Closes #10
@SeanTAllen SeanTAllen mentioned this issue Aug 15, 2020
Merged
SeanTAllen added a commit that referenced this issue Aug 15, 2020
@SeanTAllen
Add new libressl testing environment
1d952c2 
Our other libressl environment uses whatever version of libressl that
alpine's package manager installs. This new environment is tied to a
specific version of libressl that we build from source.

This gives us more control over what is tested and when we change
what is tested.

Closes #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanTAllen SeanTAllen

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new libressl testing environment ponylang/shared-docker
1 participant
@SeanTAllen