Convert only DB Engine's commit() exceptions to CommitException #159

Closed
socketpair opened this Issue Feb 4, 2016 · 0 comments

Projects

None yet

2 participants

@socketpair

In other words, exceptions, raised in hooks (like post-insert ones) must not be wrapped into CommitException anymore.

This is not backward-compatible change, so please mention that in documentation (refer to versions), and also describe new behaviour in docs.

@kozlovsky kozlovsky added this to the 0.6.4 milestone Feb 4, 2016
@kozlovsky kozlovsky self-assigned this Feb 4, 2016
@kozlovsky kozlovsky modified the milestone: 0.6.5, 0.6.4 Feb 10, 2016
@kozlovsky kozlovsky modified the milestone: 0.6.6, 0.6.5 Apr 4, 2016
@kozlovsky kozlovsky modified the milestone: 0.6.7, 0.6.6 Sep 9, 2016
@kozlovsky kozlovsky closed this in 37306ae Sep 9, 2016
@kozlovsky kozlovsky added a commit that referenced this issue Oct 11, 2016
@kozlovsky kozlovsky Pony ORM Release 0.7 (2016-10-11)
Starting with this release Pony ORM is release under the Apache License, Version 2.0.

# New features

* Added getattr() support in queries: https://docs.ponyorm.com/api_reference.html#getattr

# Backward incompatible changes

* #159: exceptions happened during flush() should not be wrapped with CommitException

Before this release an exception that happened in a hook(https://docs.ponyorm.com/api_reference.html#entity-hooks), could be raised in two ways - either wrapped into the CommitException or without wrapping. It depended if the exception happened during the execution of flush() or commit() function on the db_session exit. Now the exception happened inside the hook never will be wrapped into the CommitException.

# Bugfixes

* #190: Timedelta is not supported when using pymysql
ecc94fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment