New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composite_index with id breaks relation #170

Closed
andreymal opened this Issue Mar 10, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@andreymal

andreymal commented Mar 10, 2016

from datetime import datetime
from pony.orm import *

db = Database()

class Comment(db.Entity):
    id = PrimaryKey(int, auto=True)
    parent = Optional('Comment')
    date = Required(datetime, default=datetime.utcnow)
    text = Required(LongStr)
    answers = Set('Comment')
    composite_index(id, date)  # comment it and all will work

db.bind('sqlite', ':memory:')
db.generate_mapping(create_tables=True)
sql_debug(True)

with db_session:
    Comment(text='foo')

pony.orm.core.CommitException: Object Comment[new:1] cannot be stored in the database. OperationalError: foreign key mismatch - "Comment" referencing "Comment"

Without composite_index field id is "id" INTEGER PRIMARY KEY AUTOINCREMENT. With composite_index"id" INTEGER NOT NULL.

I don't know, maybe id with composite_index is stupid, but pony should be something to do with it :)

@andreymal andreymal changed the title from composite_index with id brakes relation to composite_index with id breaks relation Mar 10, 2016

@sashaaero sashaaero closed this in cae000f Aug 30, 2017

@kozlovsky kozlovsky assigned kozlovsky and sashaaero and unassigned kozlovsky Aug 30, 2017

@kozlovsky kozlovsky added the bug label Aug 30, 2017

@kozlovsky kozlovsky added this to the 0.7.3 milestone Aug 30, 2017

@kozlovsky

This comment has been minimized.

Show comment
Hide comment
@kozlovsky

kozlovsky Aug 30, 2017

Member

Thanks for reporting, should be fixed now

Member

kozlovsky commented Aug 30, 2017

Thanks for reporting, should be fixed now

kozlovsky added a commit that referenced this issue Oct 23, 2017

Pony ORM Release 0.7.3 (2017-10-23)
# New features

* `where()` method added to query
* `coalesce()` function added
* `between(x, a, b)` function added
* #295: Add `_table_options_` for entity class to specify engine, tablespace, etc.
* Make debug flag thread-local
* `sql_debugging` context manager added
* `sql_debug` and show_values arguments to db_session added
* `set_sql_debug` function added as alias to (to be deprecated) `sql_debug` function
* Allow `db_session` to accept `ddl` parameter when used as context manager
* Add `optimistic=True` option to db_session
* Skip optimistic checks for queries in `db_session` with `serializable=True`
* `fk_name` option added for attributes in order to specify foreign key name
* #280: Now it's possible to specify `timeout` option, as well as pass other keyword arguments for `sqlite3.connect` function
* Add support of explicit casting to int in queries using `int()` function
* Added modulo division % native support in queries

# Bugfixes

* Fix bugs with composite table names
* Fix invalid foreign key & index names for tables which names include schema name
* For queries like `select(x for x in MyObject if not x.description)` add "OR x.info IS NULL" for nullable string columns
* Add optimistic checking for `delete()` method
* Show updated attributes when `OptimisticCheckError` is being raised
* Fix incorrect aliases in nested queries
* Correctly pass exception from user-defined functions in SQLite
* More clear error messages for `UnrepeatableReadError`
* Fix `db_session(strict=True)` which was broken in 2d3afb2
* Fixes #170: Problem with a primary key column used as a part of another key
* Fixes #223: incorrect result of `getattr(entity, attrname)` when the same lambda applies to different entities
* Fixes #266: Add handler to `"pony.orm"` logger does not work
* Fixes #278: Cascade delete error: FOREIGN KEY constraint failed, with complex entity relationships
* Fixes #283: Lost Json update immediately after object creation
* Fixes #284: `query.order_by()` orders Json numbers like strings
* Fixes #288: Expression text parsing issue in Python 3
* Fixes #293: translation of if-expressions in expression
* Fixes #294: Real stack traces swallowed within IPython shell
* `Collection.count()` method should check if session is alive
* Set `obj._session_cache_` to None after exiting from db session for better garbage collection
* Unload collections which are not fully loaded after exiting from db session for better garbage collection
* Raise on unknown options for attributes that are part of relationship
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment