New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order_by orders Json numbers like strings #284

Closed
jamesstidard opened this Issue Aug 14, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@jamesstidard

jamesstidard commented Aug 14, 2017

It appears Pony is stringifying the values in json before it it orders so numbers are sorted alphabetically. Is this a known limitation?

Here's an example script:

from pony.orm import (
    Database, Required, Optional, db_session, commit,
    show, Json)

db = Database()
db.bind('sqlite', filename=':memory:', create_db=True)

class Person(db.Entity):
    name = Required(str)
    body = Optional(Json, default={})

db.generate_mapping(create_tables=True)


with db_session:
    Person(name='bort', body={'age': 1})
    Person(name='baz', body={'age': 2})
    Person(name='bar', body={'age': 10})
    Person(name='foo', body={'age': 20})

    commit()

    people = Person.select().order_by(lambda p: p.body['age'])
    show(people)
id|name|body       
--+----+-----------
1 |bort|{'age': 1} 
3 |bar |{'age': 10}
2 |baz |{'age': 2} 
4 |foo |{'age': 20}

@kozlovsky kozlovsky closed this in cf5285a Aug 25, 2017

@kozlovsky kozlovsky self-assigned this Aug 25, 2017

@kozlovsky kozlovsky added the bug label Aug 25, 2017

@kozlovsky kozlovsky added this to the 0.7.3 milestone Aug 25, 2017

@kozlovsky

This comment has been minimized.

Show comment
Hide comment
@kozlovsky

kozlovsky Aug 25, 2017

Member

Should work now in all databases except Oracle. In Oracle you need to explicitly cast value to int:

people = Person.select().order_by(lambda p: int(p.body['age']))

This is also necessary in other databases if numbers are stored in JSON as a string values

Member

kozlovsky commented Aug 25, 2017

Should work now in all databases except Oracle. In Oracle you need to explicitly cast value to int:

people = Person.select().order_by(lambda p: int(p.body['age']))

This is also necessary in other databases if numbers are stored in JSON as a string values

@jamesstidard

This comment has been minimized.

Show comment
Hide comment
@jamesstidard

jamesstidard Aug 25, 2017

@kozlovsky Second issue of mine you've taken on - much appreciated, thanks. I did try casting to an int before as a work around but I was getting the exception "TypeError: Function 'int' cannot be used this way: int(p.body['age'])". That might have been sqlite specific and not an issue anymore though.

Thanks again.

jamesstidard commented Aug 25, 2017

@kozlovsky Second issue of mine you've taken on - much appreciated, thanks. I did try casting to an int before as a work around but I was getting the exception "TypeError: Function 'int' cannot be used this way: int(p.body['age'])". That might have been sqlite specific and not an issue anymore though.

Thanks again.

kozlovsky added a commit that referenced this issue Oct 23, 2017

Pony ORM Release 0.7.3 (2017-10-23)
# New features

* `where()` method added to query
* `coalesce()` function added
* `between(x, a, b)` function added
* #295: Add `_table_options_` for entity class to specify engine, tablespace, etc.
* Make debug flag thread-local
* `sql_debugging` context manager added
* `sql_debug` and show_values arguments to db_session added
* `set_sql_debug` function added as alias to (to be deprecated) `sql_debug` function
* Allow `db_session` to accept `ddl` parameter when used as context manager
* Add `optimistic=True` option to db_session
* Skip optimistic checks for queries in `db_session` with `serializable=True`
* `fk_name` option added for attributes in order to specify foreign key name
* #280: Now it's possible to specify `timeout` option, as well as pass other keyword arguments for `sqlite3.connect` function
* Add support of explicit casting to int in queries using `int()` function
* Added modulo division % native support in queries

# Bugfixes

* Fix bugs with composite table names
* Fix invalid foreign key & index names for tables which names include schema name
* For queries like `select(x for x in MyObject if not x.description)` add "OR x.info IS NULL" for nullable string columns
* Add optimistic checking for `delete()` method
* Show updated attributes when `OptimisticCheckError` is being raised
* Fix incorrect aliases in nested queries
* Correctly pass exception from user-defined functions in SQLite
* More clear error messages for `UnrepeatableReadError`
* Fix `db_session(strict=True)` which was broken in 2d3afb2
* Fixes #170: Problem with a primary key column used as a part of another key
* Fixes #223: incorrect result of `getattr(entity, attrname)` when the same lambda applies to different entities
* Fixes #266: Add handler to `"pony.orm"` logger does not work
* Fixes #278: Cascade delete error: FOREIGN KEY constraint failed, with complex entity relationships
* Fixes #283: Lost Json update immediately after object creation
* Fixes #284: `query.order_by()` orders Json numbers like strings
* Fixes #288: Expression text parsing issue in Python 3
* Fixes #293: translation of if-expressions in expression
* Fixes #294: Real stack traces swallowed within IPython shell
* `Collection.count()` method should check if session is alive
* Set `obj._session_cache_` to None after exiting from db session for better garbage collection
* Unload collections which are not fully loaded after exiting from db session for better garbage collection
* Raise on unknown options for attributes that are part of relationship
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment