New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move defer statement into http handler function #219

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
2 participants
@robbawebba
Contributor

robbawebba commented Jan 8, 2018

These changes move a defer block that closes the gzip writer into the gzip middleware handler.

Thanks @nilslice for the opportunity to contribute!

Closes #205

@nilslice

This comment has been minimized.

Show comment
Hide comment
@nilslice

nilslice Jan 8, 2018

Member

LGTM! Thanks @robbawebba - I'm going to change the base to ponzu-dev for this PR, then proceed the merge from there.

Member

nilslice commented Jan 8, 2018

LGTM! Thanks @robbawebba - I'm going to change the base to ponzu-dev for this PR, then proceed the merge from there.

@nilslice nilslice changed the base branch from master to ponzu-dev Jan 8, 2018

@nilslice nilslice merged commit c8640a8 into ponzu-cms:ponzu-dev Jan 8, 2018

@robbawebba

This comment has been minimized.

Show comment
Hide comment
@robbawebba

robbawebba Jan 8, 2018

Contributor

Thanks @nilslice! I've got a quick question about the development workflow. Do I have to create a new ponzu project with ponzu new every time I want to test changes I've made to the source? If so, do those changes have to be in a commit? or can they be unstaged/uncommited?

Contributor

robbawebba commented Jan 8, 2018

Thanks @nilslice! I've got a quick question about the development workflow. Do I have to create a new ponzu project with ponzu new every time I want to test changes I've made to the source? If so, do those changes have to be in a commit? or can they be unstaged/uncommited?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment