Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't support baseurl #38

Closed
RyanMarcus opened this issue May 8, 2014 · 3 comments
Closed

Doesn't support baseurl #38

RyanMarcus opened this issue May 8, 2014 · 3 comments
Milestone
v3.0.0

Comments

@RyanMarcus
Copy link

@RyanMarcus RyanMarcus commented May 8, 2014

It seems to be a Jekyll convention to use baseurl to give the base URL of a site. The head.html file seems to assume that the public folder will be available at /, which is not always the case.
@parkr
Copy link
Contributor

@parkr parkr commented May 8, 2014

It seems to be a Jekyll convention to use baseurl to give the base URL of a site.

The base path, to be exact, i.e. the /hi of http://example.org/hi.

@RyanMarcus
Copy link
Author

@RyanMarcus RyanMarcus commented May 8, 2014

Ah, yes. That's correct. My bad.

@mdo mdo added this to the v2.1.0 milestone Jun 23, 2014
@mdo mdo closed this as completed in 802cbd1 Jun 23, 2014
@RyanMarcus
Copy link
Author

@RyanMarcus RyanMarcus commented Jul 14, 2014

Thanks for fixing this! I appreciate it, along with the rest of the work you've done with theme. I think you may have missed one link in sidebar.html.

<a class="sidebar-nav-item{% if page.url == node.url %} active{% endif %}" href="{{ node.url }}">{{ node.title }}</a>

I'm not sure if node.url is supposed to automatically include the base, but it doesn't seem to do so with my setup.

toastking added a commit to toastking/old.toastking.github.io that referenced this issue Feb 13, 2015
@toastking
Merge branch 'master' of https://github.com/toastking/toastking.githu…
cd40972 
…b.io

# By Mark Otto (71) and others
# Via Mark Otto (14) and Н. У. Брак (1)
* 'master' of https://github.com/toastking/toastking.github.io: (83 commits)
  Fixed a small typo
  Changed layout to null in atom.xml
  fixes poole#52: increases line-height on sidebar nav links for easier tapping
  Use relative permalinks
  "pygments" tag is deprecated
  fixes poole#44: permalink url for 404 page
  ensure IE is running in latest rendering mode
  port in sidebar nav from lanyon
  latest example content from poole
  link the h1 in the sidebar
  baseurl, fixes poole#38
  fixes poole#37
  ems not rems
  latest poole
  Update _config.yml to remove deprecation warning in Jekyll 2.0
  Set a max-width for images
  Sublime Text link
  Changed "Lanyon" for "Hyde" in the features paragraph
  Fix page title on homepage.
  fixes poole#27: new icons
  ...
BrunoMiguens pushed a commit to BrunoMiguens/brunomiguens.github.io that referenced this issue Mar 19, 2019
@sparanoid
Merge pull request poole#38 from sparanoid/greenkeeper-grunt-contrib-…
44a2108 
…cssmin-1.0.0

Update grunt-contrib-cssmin to version 1.0.0 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
3 participants
@mdo @parkr @RyanMarcus