Doesn't support baseurl #38

Closed
RyanMarcus opened this Issue May 8, 2014 · 3 comments

Projects

None yet

3 participants

@RyanMarcus

It seems to be a Jekyll convention to use baseurl to give the base URL of a site. The head.html file seems to assume that the public folder will be available at /, which is not always the case.

@parkr
Contributor
parkr commented May 8, 2014

It seems to be a Jekyll convention to use baseurl to give the base URL of a site.

The base path, to be exact, i.e. the /hi of http://example.org/hi.

@RyanMarcus

Ah, yes. That's correct. My bad.

@mdo mdo added this to the v2.1.0 milestone Jun 23, 2014
@mdo mdo added a commit that closed this issue Jun 23, 2014
@mdo mdo baseurl, fixes #38 802cbd1
@mdo mdo closed this in 802cbd1 Jun 23, 2014
@RyanMarcus

Thanks for fixing this! I appreciate it, along with the rest of the work you've done with theme. I think you may have missed one link in sidebar.html.

<a class="sidebar-nav-item{% if page.url == node.url %} active{% endif %}" href="{{ node.url }}">{{ node.title }}</a>

I'm not sure if node.url is supposed to automatically include the base, but it doesn't seem to do so with my setup.

@lastnamevega lastnamevega pushed a commit to lastnamevega/lastnamevega.github.io that referenced this issue Jan 6, 2015
@mdo mdo baseurl, fixes #38 97736bc
@toastking toastking added a commit to toastking/toastking.github.io that referenced this issue Feb 13, 2015
@toastking toastking Merge branch 'master' of https://github.com/toastking/toastking.githu…
…b.io

# By Mark Otto (71) and others
# Via Mark Otto (14) and Н. У. Брак (1)
* 'master' of https://github.com/toastking/toastking.github.io: (83 commits)
  Fixed a small typo
  Changed layout to null in atom.xml
  fixes #52: increases line-height on sidebar nav links for easier tapping
  Use relative permalinks
  "pygments" tag is deprecated
  fixes #44: permalink url for 404 page
  ensure IE is running in latest rendering mode
  port in sidebar nav from lanyon
  latest example content from poole
  link the h1 in the sidebar
  baseurl, fixes #38
  fixes #37
  ems not rems
  latest poole
  Update _config.yml to remove deprecation warning in Jekyll 2.0
  Set a max-width for images
  Sublime Text link
  Changed "Lanyon" for "Hyde" in the features paragraph
  Fix page title on homepage.
  fixes #27: new icons
  ...
cd40972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment