New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard focus styles #103

Merged
merged 1 commit into from Apr 19, 2015

Conversation

Projects
None yet
2 participants
@mdo
Member

mdo commented Apr 19, 2015

Fixes #89 (a bit).

Improves accessibility by styling the sidebar toggle as selected on tab.

@mdo mdo added this to the v2.0.0 milestone Apr 19, 2015

mdo added a commit that referenced this pull request Apr 19, 2015

@mdo mdo merged commit bec9ea9 into master Apr 19, 2015

@mdo mdo deleted the focus branch Apr 19, 2015

@fabiolib

This comment has been minimized.

Show comment
Hide comment
@fabiolib

fabiolib Aug 27, 2015

Removing display:none from .sidebar-checkbox seems to have the adverse affect of jumping to the top of the page (where the invisible checkbox still exists) whenever the menu is toggled. I'm investigating making these changes to the class @media specific for accessibility devices, but there doesn't seem to be a consensus on how to do that.

fabiolib commented on f039ccb Aug 27, 2015

Removing display:none from .sidebar-checkbox seems to have the adverse affect of jumping to the top of the page (where the invisible checkbox still exists) whenever the menu is toggled. I'm investigating making these changes to the class @media specific for accessibility devices, but there doesn't seem to be a consensus on how to do that.

imyeonn pushed a commit to imyeonn/imyeonn.github.io3 that referenced this pull request Jan 15, 2017

Merge pull request #103 from jehartzog/refactor-pages
Refactored blog html and layouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment