From 11faeb1b00d9aede1ab162a6df2948dcdd6dd53c Mon Sep 17 00:00:00 2001
From: Brendan Asselstine <mail.asselstine@gmail.com>
Date: Wed, 13 Oct 2021 20:45:46 -0700
Subject: [PATCH] Created constant in PrizeSplit (#241)

---
 contracts/prize-strategy/PrizeSplit.sol | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/contracts/prize-strategy/PrizeSplit.sol b/contracts/prize-strategy/PrizeSplit.sol
index 4f36532e..299f19cf 100644
--- a/contracts/prize-strategy/PrizeSplit.sol
+++ b/contracts/prize-strategy/PrizeSplit.sol
@@ -14,6 +14,8 @@ abstract contract PrizeSplit is IPrizeSplit, Ownable {
     /* ============ Global Variables ============ */
     PrizeSplitConfig[] internal _prizeSplits;
 
+    uint16 public constant ONE_AS_FIXED_POINT_3 = 1000;
+
     /* ============ External Functions ============ */
 
     /// @inheritdoc IPrizeSplit
@@ -79,7 +81,7 @@ abstract contract PrizeSplit is IPrizeSplit, Ownable {
 
         // Total prize split do not exceed 100%
         uint256 totalPercentage = _totalPrizeSplitPercentageAmount();
-        require(totalPercentage <= 1000, "PrizeSplit/invalid-prizesplit-percentage-total");
+        require(totalPercentage <= ONE_AS_FIXED_POINT_3, "PrizeSplit/invalid-prizesplit-percentage-total");
     }
 
     /// @inheritdoc IPrizeSplit
@@ -96,7 +98,7 @@ abstract contract PrizeSplit is IPrizeSplit, Ownable {
 
         // Total prize split do not exceed 100%
         uint256 totalPercentage = _totalPrizeSplitPercentageAmount();
-        require(totalPercentage <= 1000, "PrizeSplit/invalid-prizesplit-percentage-total");
+        require(totalPercentage <= ONE_AS_FIXED_POINT_3, "PrizeSplit/invalid-prizesplit-percentage-total");
 
         // Emit updated prize split config
         emit PrizeSplitSet(
@@ -119,7 +121,7 @@ abstract contract PrizeSplit is IPrizeSplit, Ownable {
         pure
         returns (uint256)
     {
-        return (_amount * _percentage) / 1000;
+        return (_amount * _percentage) / ONE_AS_FIXED_POINT_3;
     }
 
     /**