From b4d0b5b03c20fdf83f58a54a2d4c8d90effb89c2 Mon Sep 17 00:00:00 2001 From: Brendan Asselstine Date: Wed, 13 Oct 2021 20:39:09 -0700 Subject: [PATCH] PR comments --- contracts/prize-pool/YieldSourcePrizePool.sol | 5 +++-- test/prize-pool/YieldSourcePrizePool.test.ts | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/contracts/prize-pool/YieldSourcePrizePool.sol b/contracts/prize-pool/YieldSourcePrizePool.sol index 7f6d0291..2c5c1588 100644 --- a/contracts/prize-pool/YieldSourcePrizePool.sol +++ b/contracts/prize-pool/YieldSourcePrizePool.sol @@ -66,9 +66,10 @@ contract YieldSourcePrizePool is PrizePool { /// @param _externalToken The address of the token to check /// @return True if the token may be awarded, false otherwise function _canAwardExternal(address _externalToken) internal view override returns (bool) { + IYieldSource _yieldSource = yieldSource; return ( - _externalToken != address(yieldSource) && - _externalToken != yieldSource.depositToken() + _externalToken != address(_yieldSource) && + _externalToken != _yieldSource.depositToken() ); } diff --git a/test/prize-pool/YieldSourcePrizePool.test.ts b/test/prize-pool/YieldSourcePrizePool.test.ts index 82de5d4a..3698ee34 100644 --- a/test/prize-pool/YieldSourcePrizePool.test.ts +++ b/test/prize-pool/YieldSourcePrizePool.test.ts @@ -141,6 +141,10 @@ describe('YieldSourcePrizePool', function () { it('should not allow the prize pool to award its token, as its likely the receipt', async () => { expect(await prizePool.canAwardExternal(yieldSource.address)).to.equal(false); }); + + it('should not allow the prize pool to award the deposit token', async () => { + expect(await prizePool.canAwardExternal(depositToken.address)).to.equal(false); + }) }); describe('sweep()', () => {