New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ticket): remove unnecessary uint224 casts #166

Merged

asselstine merged 1 commit into master from pool-1658-no-need-for-uint224-cast-in-ticket

Oct 6, 2021

Contributor

PierrickGT commented Oct 5, 2021

No description provided.


          fix(Ticket): remove unnecessary uint224 casts

f39449b

PierrickGT requested review from kamescg, asselstine and aodhgan

October 5, 2021 15:08

linear bot commented Oct 5, 2021

POOL-1658 No need for uint224 cast in Ticket

File: https://github.com/pooltogether/pooltogether-contract-tsunami/blob/fb9a8e18fbf29f65b6da4d9fdc7657c2ddd6aab6/contracts/Ticket.sol

Several downsize to uint224 are unneeded since calculations are performed in uint256 and functions params accept uint256.

Lines that are concerned are the followings:

https://github.com/pooltogether/pooltogether-contract-tsunami/blob/fb9a8e18fbf29f65b6da4d9fdc7657c2ddd6aab6/contracts/Ticket.sol#L202
https://github.com/pooltogether/pooltogether-contract-tsunami/blob/fb9a8e18fbf29f65b6da4d9fdc7657c2ddd6aab6/contracts/Ticket.sol#L268
v4-core/contracts/Ticket.sol

Line 314 in fb9a8e1

uint224 amount = _amount.toUint224();
v4-core/contracts/Ticket.sol

Line 353 in fb9a8e1

uint224 amount = _amount.toUint224();

asselstine approved these changes

View reviewed changes

Contributor

asselstine left a comment

LGTM; but tests need to pass

asselstine merged commit 21d2561 into master

asselstine deleted the pool-1658-no-need-for-uint224-cast-in-ticket branch

October 6, 2021 02:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet