Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening the app library on a workspace with no open windows, I have to hit Esc twice to close the app library #10

Closed
leviport opened this issue Aug 23, 2022 · 7 comments

Comments

@leviport
Copy link
Member

leviport commented Aug 23, 2022

Summary:

Closing the app library with Esc takes a double Esc press to close it if I open the app library on a workspace with no open windows. If I have a browser window open and open the app library over the top of it, a single Esc press is enough to close it.

Steps to reproduce:

  • Switch to a workspace with no open windows
  • Open the app library with Super + A
  • Hit Esc once, app library should not close
  • Hit Esc again, app library should close after the second press

Expected behavior:

It should probably close after a single Esc press, like it does when I open it on a workspace with a window open.

Version:

$ apt policy cosmic-app-library 
cosmic-app-library:
  Installed: 0.1.0~1660784434~22.04~dc85e14
  Candidate: 0.1.0~1660784434~22.04~dc85e14
  Version table:
 *** 0.1.0~1660784434~22.04~dc85e14 1002
       1001 http://apt.pop-os.org/release jammy/main amd64 Packages
       1002 http://apt.pop-os.org/staging/master jammy/main amd64 Packages
        100 /var/lib/dpkg/status
@leviport
Copy link
Member Author

Oh it seems like it can happen with certain applications open as well. Single Esc works nicely on a workspace with a Firefox window open, but it needs a double Esc on a workspace with Gnome Terminal or LibreOffice windows open.

@leviport
Copy link
Member Author

Ah, the second keypress doesn't even need to be Esc, it can by any key. So Esc then spacebar, or Esc then B, will close the app library. I'm also seeing the same thing happen with the launcher, so this might be more of a general COSMIC bug rather than one specific to the app library.

@wash2
Copy link
Collaborator

wash2 commented Aug 25, 2022

Ya this is probably more an issue with https://github.com/pop-os/cosmic-applet-host

@Drakulix
Copy link
Member

Ah, the second keypress doesn't even need to be Esc, it can by any key. So Esc then spacebar, or Esc then B, will close the app library. I'm also seeing the same thing happen with the launcher, so this might be more of a general COSMIC bug rather than one specific to the app library.

Sounds like it is missing a re-render?
Could also be cosmic-comp not realizing the layer-shell surface is gone. 🤔

@leviport
Copy link
Member Author

Sounds like it is missing a re-render?

Yeah that sounds pretty likely. I've seen other occurrences of what look like missing re-renders, but they're quite a bit harder to reproduce reliably. The one I see the most often is when I open a new terminal with Super+T on an empty workspace. Sometimes it doesn't appear until I press another key. I'll report back if I find a way to make it happen more reliably.

@wash2
Copy link
Collaborator

wash2 commented Aug 26, 2022

Could also be cosmic-comp not realizing the layer-shell surface is gone. thinking

Ya at the point after I've destroyed the surface, I probably can't do another render, right? I can recreate this issue, but ya it's weird that the surface only disappears after some additional key press or mouse movement.

@leviport
Copy link
Member Author

leviport commented Dec 1, 2022

Looks like this is fixed now

@leviport leviport closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants