Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #63 #65

Closed
wants to merge 4 commits into from
Closed

Fixes issue #63 #65

wants to merge 4 commits into from

Conversation

evertiro
Copy link

@evertiro evertiro commented Nov 6, 2018

Activity search was being over-ridden, fix it.

@evertiro
Copy link
Author

evertiro commented Nov 6, 2018

Oops, build deps was supposed to be a separate PR, sorry about that.

@brs17 brs17 requested review from isantop and brs17 November 6, 2018 15:08
Copy link
Contributor

@isantop isantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single tiny note, otherwise looks good.

README.md Outdated Show resolved Hide resolved
src/common/sass/widgets/_activities.scss Show resolved Hide resolved
@brs17
Copy link
Contributor

brs17 commented Dec 11, 2018

When trying to test this, after building the theme and rebooting I no longer have a Pop option under "Applications" in gnome-tweak-tool. I have Pop-{,dark,light}{,slim} options but no default Pop. And this was after setting "Applications" and "Shell" to Pop-dark.

@brs17
Copy link
Contributor

brs17 commented Jan 2, 2019

Per conversation with @evertiro, closing as it most likely needs to be redone.

@brs17 brs17 closed this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants