Version 4.0.1 #225
Merged
Version 4.0.1 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use equivalently size borders between states in terminal. Otherwise we end up with the terminal window contents "jumping" up and down when the window is :backdrop'd or not. Fixes #217
We don't want borders on the top of the box, otherwise the border runs between the menubar and the titlebar
|
@brs17 Addressed, thanks. |
|
|
|
This patch now does seem to successfully fix the listed issues. |
jackpot51
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bugfix update to Version 4:
Fixes #217
Fixes #219
Fixes #223
Depends on #222 due to changelog updates.