Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Non-Blurry Switches and Checks #277

Merged
merged 5 commits into from Apr 8, 2019

Conversation

@isantop
Copy link
Collaborator

@isantop isantop commented Feb 18, 2019

Use pre-rendered assets to ensure sharpness

GTK CSS seems to render SVG assets to PNG prior to scaling them. This results in a blurry
image for the switches, checkboxes, and radio buttons on HiDPI. Instead, we should
pre-render these images at 1x, 2x, and 3x sizes to ensure they are always sharp.

This allows us to have sharp images at all sizes, and to avoid depending on the
icon theme to provide these images (icons are also always sharp). Otherwise there would
be no images if a user was using the gtk theme with a different icon theme.

Ian Santopietro added 2 commits Feb 18, 2019
GTK CSS seems to render SVG assets to PNG prior to scaling them. This results in a blurry
image for the switches, checkboxes, and radio buttons on HiDPI. Instead, we should
pre-render these images at 1x, 2x, and 3x sizes to ensure they are always sharp.

This allows us to have sharp images at all sizes, and to avoid depending on the
icon theme to provide these images (icons are also always sharp). Otherwise there would
be no images if a user was using the gtk theme with a different icon theme.
@isantop isantop self-assigned this Feb 18, 2019
@isantop isantop requested review from brs17 and jackpot51 Feb 18, 2019
@brs17
Copy link
Member

@brs17 brs17 commented Apr 8, 2019

@isantop are we purposefully changing the gtk-theming in 18.04 to look more like the ones in 18.10?

Before:
Screenshot from 2019-04-08 10-44-50

After:
Screenshot from 2019-04-08 10-51-08

@isantop
Copy link
Collaborator Author

@isantop isantop commented Apr 8, 2019

@brs17 Yes, there is no distinction between branches anymore. That's already in master. Update, reload the theme, then add the patch to see what I mean

@brs17
Copy link
Member

@brs17 brs17 commented Apr 8, 2019

You're right, I was doing too many things at once 😢

brs17
brs17 approved these changes Apr 8, 2019
@isantop isantop merged commit dcee6b3 into master Apr 8, 2019
8 checks passed
@isantop isantop deleted the feature-non-blurry-switch-checks branch Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants