Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust sizing and headerbars for new hdy widgets #281

merged 5 commits into from Apr 3, 2019


None yet
3 participants
Copy link

commented Feb 26, 2019

Some applications in Disco now use hdytitlebar widgets, which are designed to split the headerbar for use with phones. The current Pop theme doesn't really support these really well, as evidenced by GNOME Control Center having no space between the edge of the headerbars and the close buttons:

screenshot from 2019-02-26 10-11-15

This PR addresses these issues.

@isantop isantop self-assigned this Feb 26, 2019

@isantop isantop requested review from brs17 and jackpot51 Feb 26, 2019

Ian Santopietro added some commits Mar 1, 2019

@brs17 brs17 added the 19.04 label Mar 30, 2019

isantop added some commits Apr 1, 2019


This comment has been minimized.

Copy link

commented Apr 1, 2019

This looks good up to the 40097a2 commit. Will look at again once the merges with master build.


brs17 approved these changes Apr 3, 2019


mmstick approved these changes Apr 3, 2019

@mmstick mmstick merged commit 4322172 into master Apr 3, 2019

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
pop-os/staging/bionic/binary Pop!_OS Staging bionic/binary
pop-os/staging/bionic/source Pop!_OS Staging bionic/source
pop-os/staging/cosmic/binary Pop!_OS Staging cosmic/binary
pop-os/staging/cosmic/source Pop!_OS Staging cosmic/source
pop-os/staging/disco/binary Pop!_OS Staging disco/binary
pop-os/staging/disco/source Pop!_OS Staging disco/source

@isantop isantop deleted the bugfix-disco-hdy-headerbars branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.