New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream application icons and branding should be respected #21

Open
isantop opened this Issue Oct 31, 2017 · 10 comments

Comments

Projects
None yet
6 participants
@isantop
Collaborator

isantop commented Oct 31, 2017

From @chergert on September 29, 2017 10:31

Issue/Bug Description

The pop-icon-theme is overriding the branding of Builder. Our application icon is our branding and having it overridden by default is not helpful to us.

Steps to reproduce (if you know)

Install Builder from apt or via Flatpak.

Expected behaviour

Application developers icons and branding are respected.

Other Notes

I understand Pop!_OS might have a desire for a unified style on the OS that is shipped. But consider third-party application authors and how their brand is equally important to them.

Imagine shipping an app in the Android store and it having different branding on Sony phones.

You might consider breaking up the icon theme into tiers with a core set of icons for applications shipped as part of the OS and an additional package users can install to "override all my applications to look like my OS instead of as the authors intended".

Copied from original issue: pop-os/iso#103

@isantop

This comment has been minimized.

Show comment
Hide comment
@isantop

isantop Oct 31, 2017

Collaborator

From @jackpot51 on September 29, 2017 14:33

Thanks for reporting this. We will discuss your suggestion of moving application icons to a separate package, thus using the default icon for most applications.

Collaborator

isantop commented Oct 31, 2017

From @jackpot51 on September 29, 2017 14:33

Thanks for reporting this. We will discuss your suggestion of moving application icons to a separate package, thus using the default icon for most applications.

@brs17

This comment has been minimized.

Show comment
Hide comment
@brs17

brs17 May 18, 2018

Member

We want to maintain a consistent user experience and feel that the icon-theme helps in that regard.

Member

brs17 commented May 18, 2018

We want to maintain a consistent user experience and feel that the icon-theme helps in that regard.

@brs17 brs17 closed this May 18, 2018

@snwh

This comment has been minimized.

Show comment
Hide comment
@snwh

snwh May 19, 2018

FWIW, a consistent specific look and feel for Pop!_OS can be achieved without a total-coverage icon theme.

A solution would be to strip all icons that impact third-party applications from the theme leaving what constitutes a "core" icon set behind–this would leave something like all folders and system icons in place.

An "extension" of the icon theme could then be provided that users can optionally install which would include all these third-party icons. This extension would be a user-level modification and not constitute an infringement of third-party brands at the vendor-level.

snwh commented May 19, 2018

FWIW, a consistent specific look and feel for Pop!_OS can be achieved without a total-coverage icon theme.

A solution would be to strip all icons that impact third-party applications from the theme leaving what constitutes a "core" icon set behind–this would leave something like all folders and system icons in place.

An "extension" of the icon theme could then be provided that users can optionally install which would include all these third-party icons. This extension would be a user-level modification and not constitute an infringement of third-party brands at the vendor-level.

@jackpot51

This comment has been minimized.

Show comment
Hide comment
@jackpot51

jackpot51 May 19, 2018

Member

@brs17 we did not make a final decision on this, I am reopening

Member

jackpot51 commented May 19, 2018

@brs17 we did not make a final decision on this, I am reopening

@jackpot51 jackpot51 reopened this May 19, 2018

@jackpot51 jackpot51 self-assigned this May 21, 2018

@jackpot51

This comment has been minimized.

Show comment
Hide comment
@jackpot51

jackpot51 May 21, 2018

Member

@chergert I am working on this now

Member

jackpot51 commented May 21, 2018

@chergert I am working on this now

@jackpot51

This comment has been minimized.

Show comment
Hide comment
@jackpot51

jackpot51 May 21, 2018

Member

I have a PR, #33, that addresses the GNOME Builder icon by blacklisting it from the installed by default package. We will need to create either a whitelist of application icons we want to include, or update this blacklist of applications we do not want to include.

Member

jackpot51 commented May 21, 2018

I have a PR, #33, that addresses the GNOME Builder icon by blacklisting it from the installed by default package. We will need to create either a whitelist of application icons we want to include, or update this blacklist of applications we do not want to include.

@aral

This comment has been minimized.

Show comment
Hide comment
@aral

aral Aug 18, 2018

I was just about to open an issue about this as the Builder icon is not consistent with the rest of the icons. It’s an eye sore next to the rest of the flat icons. Please reconsider blacklisting it.

aral commented Aug 18, 2018

I was just about to open an issue about this as the Builder icon is not consistent with the rest of the icons. It’s an eye sore next to the rest of the flat icons. Please reconsider blacklisting it.

@jackpot51

This comment has been minimized.

Show comment
Hide comment
@jackpot51

jackpot51 Aug 18, 2018

Member

@aral install the pop-icon-theme-extra package

Member

jackpot51 commented Aug 18, 2018

@aral install the pop-icon-theme-extra package

@aral

This comment has been minimized.

Show comment
Hide comment
@aral

aral Aug 19, 2018

@jackpot51 Thanks, I can easily do that. My point was about the overall consistency of the OS. People shouldn’t have to install a separate package to get consistency. (You’ve done an amazing job of crafting a consistent OS out of so many moving parts; it’s just sad to see such a simple thing break that consistency.)

aral commented Aug 19, 2018

@jackpot51 Thanks, I can easily do that. My point was about the overall consistency of the OS. People shouldn’t have to install a separate package to get consistency. (You’ve done an amazing job of crafting a consistent OS out of so many moving parts; it’s just sad to see such a simple thing break that consistency.)

@chergert

This comment has been minimized.

Show comment
Hide comment
@chergert

chergert Aug 19, 2018

@aral As the upstream author of Builder, I don't want my applications branding overridden by default. I want all of the Builder materials and web properties to match so people know things are correct as they move between applications and external product materials.

It's very much fine for users to change things if they wish, because they are aware of the difference.

chergert commented Aug 19, 2018

@aral As the upstream author of Builder, I don't want my applications branding overridden by default. I want all of the Builder materials and web properties to match so people know things are correct as they move between applications and external product materials.

It's very much fine for users to change things if they wish, because they are aware of the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment