#476 fix(UX): Rename 'local' endpoint doesn't overwrite "unix://" #477

Merged
merged 2 commits into from Jan 12, 2017

Projects

None yet

2 participants

@Kilhog
Contributor
Kilhog commented Jan 7, 2017

This is a fix to the issue #476

@deviantony

Need a little change.

@@ -19,7 +19,8 @@ function ($scope, $state, $stateParams, $filter, EndpointService, Messages) {
var TLSCACert = $scope.formValues.TLSCACert !== $scope.endpoint.TLSCACert ? $scope.formValues.TLSCACert : null;
var TLSCert = $scope.formValues.TLSCert !== $scope.endpoint.TLSCert ? $scope.formValues.TLSCert : null;
var TLSKey = $scope.formValues.TLSKey !== $scope.endpoint.TLSKey ? $scope.formValues.TLSKey : null;
- EndpointService.updateEndpoint(ID, name, URL, TLS, TLSCACert, TLSCert, TLSKey).then(function success(data) {
+ var TYPE = $scope.endpointType;
@deviantony
deviantony Jan 9, 2017 Collaborator

Please just replace the TYPE variable with a lowercase name, e.g. type.

app/shared/services.js
@@ -374,11 +374,11 @@ angular.module('portainer.services', ['ngResource', 'ngSanitize'])
endpoints: function() {
return Endpoints.query({}).$promise;
},
- updateEndpoint: function(ID, name, URL, TLS, TLSCAFile, TLSCertFile, TLSKeyFile) {
+ updateEndpoint: function(ID, name, URL, TLS, TLSCAFile, TLSCertFile, TLSKeyFile, TYPE) {
@deviantony
deviantony Jan 9, 2017 Collaborator

Same here, see my comment above.

@Kilhog
Contributor
Kilhog commented Jan 9, 2017

Done

@deviantony

LGTM

@deviantony deviantony merged commit cd26051 into portainer:develop Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment