FeedQuoteProvider von einer Security URL #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the parsing stop after the content table is finished, so that tables comming afterwards do not make it fail.
with a vanilla main method because the author was not able to do it otherwise...
should now work on all historic chart tables from finanzen.net
Conflicts: name.abuchen.portfolio/src/name/abuchen/portfolio/model/InvestmentPlan.java name.abuchen.portfolio/src/name/abuchen/portfolio/online/ImportFinanzenNetQuotes.java portfolio-app/pom.xml
and failing to do so
parsing of a entered url and extracting the prices from that page.
to a more generic name
|
Mir ist vollkommen klar, dass "master" nicht der richtige branch dafür ist. |
Conflicts: name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/wizards/EditSecurityWizard.java name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/wizards/SecurityMasterDataPage.java name.abuchen.portfolio/META-INF/services/name.abuchen.portfolio.online.QuoteFeed name.abuchen.portfolio/src/name/abuchen/portfolio/model/Security.java portfolio-product/name.abuchen.portfolio.product
making the Feed return an empty list of exchanges
refactored the feed internals to be able to answer the historicalQuotes request
|
Okay, der branch ist nun up-to-date mit master und das Feature funktioniert meiner Meinung nach gut genug, um sich darüber zu unterhalten. Was geht gut? Was geht nicht gut?
|
buchen
added a commit
that referenced
this pull request
Jan 19, 2014
The feed provider tries to detect a table in the HTML loaded from the feed URL. Based on the column headers it determines the types to extract values from the table. Issue: #114
buchen
added a commit
that referenced
this pull request
Jan 25, 2014
- support thead element when defining the columns - support other date format pattern - support more column labels - check if mandatory columns date and close exist Issue: #114
buchen
added a commit
that referenced
this pull request
Jan 26, 2014
- sites return an alternative/mobile version if no user-agent is set - log HTML if now quotes are found to support troubleshooting - support more column labels: English labels Issue: #114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
die URL kann in den Eigenschaften der security gespeichert werden (evtl gibt es einen besseren Platz diese einzutragen als momentan).
Diese URL wird geladen und die Preise daraus geparsed.
Let the discussion begin!