Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clone check #779

Open
Kirzi opened this issue Apr 12, 2017 · 3 comments

Comments

@Kirzi
Copy link
Contributor

commented Apr 12, 2017

Right now, static PID events and limited PID events are incorrectly flagged as clones, since we don't use IVs to check for clones.

I think we should change that, and use IVs (edit: and nature) to match clones. We didn't originally since people can hack IVs to avoid detection, but at the moment, it doesn't seem worth it.

I'd rather implement a separate check for "almost clones", or a search function so that people can look manually, or something along those lines.

@Kirzi Kirzi added the enhancement label Apr 12, 2017
@McInkay

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2017

This summarises my points:

08:45 ~YaManicKill I've never understood the argument for not including IVs in the clone checkef.
08:45 ~YaManicKill If we are saying "Someone can change it" then surely that's the same for everything else we check for clones as well.
08:47 Kirzi In hindsight it does seem sort of weird 
08:47 Kirzi Though, IVs are much more likely to be altered than anything else
09:04 ~YaManicKill But the point is if someone knows how to edit a pokemon, and they care about it being a clone, they'll know what to do.
09:10 Kirzi Depends on who they're trying to fool. Changing IVs is sufficient for 99% of trades since most people won't check it in Porybox or Pkhex
09:11 Kirzi Plus I doubt PS can reroll PID and such
09:12 Kirzi Overall though it's better to count IVs and then worry about that separately maybe
09:12 Kirzi Too many false alarms now
09:18 ~YaManicKill Yeah, well, that's the other point.

I think we should add IVs into clone check.

@Kirzi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2017

I'll also reference #548 in case we want to try to knock that out here too.

@McInkay

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2017

Oh goodness, no...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.