New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 404 when no comments #301

Open
claudio4 opened this Issue Jan 22, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@claudio4

claudio4 commented Jan 22, 2017

When there are not comments the server response is a 404 error and this is bad beacause de browsers and the search engines detect it as a broken link, please replace the 404 error to something like no comments.

Tanks for your time and nice project

@Tetsumaki

This comment has been minimized.

Tetsumaki commented Jul 11, 2017

+1 for this issue please.

@zontarian

This comment has been minimized.

zontarian commented Oct 14, 2017

Yes, an empty array would be preferable or something like that.

@jelmer

This comment has been minimized.

Collaborator

jelmer commented Oct 15, 2017

How would isso know what valid pages are? The alternative is returning a 200, but also for pages that don't actually exist.

@claudio4

This comment has been minimized.

claudio4 commented Oct 15, 2017

An option could be to return a 204 (No Content).

@jelmer

This comment has been minimized.

Collaborator

jelmer commented Oct 15, 2017

Still, how would isso know which URLs are for valid pages and which ones aren't? Presumably you'd only want to return a 204 for comments on pages that exist, but a 404 for pages that don't exist.

@claudio4

This comment has been minimized.

claudio4 commented Oct 15, 2017

Which is the point of knowing if a page doesn't exists if you can send a comment anyway and create it?

@jelmer

This comment has been minimized.

Collaborator

jelmer commented Oct 15, 2017

That's a fair point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment