Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hungarian translation #355

Merged
merged 1 commit into from Nov 22, 2017
Merged

Conversation

@mpchadwick
Copy link
Contributor

@mpchadwick mpchadwick commented Nov 22, 2017

#350 introduces an error per #350 (comment)

@jelmer jelmer merged commit 0232051 into posativ:master Nov 22, 2017
1 check passed
Loading
@@ -3,7 +3,7 @@ define(["app/config", "app/i18n/bg", "app/i18n/cs", "app/i18n/da",
"app/i18n/fr", "app/i18n/hr", "app/i18n/ru", "app/i18n/it",
"app/i18n/eo", "app/i18n/sv", "app/i18n/nl", "app/i18n/el_GR",
"app/i18n/es", "app/i18n/vi", "app/i18n/zh_CN", "app/i18n/zh_CN", "app/i18n/zh_TW", "app/i18n/hu"],
function(config, bg, cs, da, de, en, fa, fi, fr, hr, ru, it, eo, sv, nl, el, es, vi, zh, zh_CN, zh_TW) {
function(config, bg, cs, da, de, en, fa, fi, fr, hr, hu, ru, it, eo, sv, nl, el, es, vi, zh, zh_CN, zh_TW) {
Copy link
Contributor Author

@mpchadwick mpchadwick Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, did I do this wrong? "app/il8n/hu" is the last element in the prior array. I'm wondering if this will screw up translations for anything after hr? Seems like the best things is to put app/i18n/hu into alphabetical order (as all the others are)?

cc @jelmer

Loading

Copy link
Contributor Author

@mpchadwick mpchadwick Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it's definitely broken. Will fix this.

image

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants