refactor: remove unnecessary get_connect(), get_content(), get_variant() R6 methods #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Just access the R6 slots directly. Remove ambiguity about which pattern we want to use (#459 (comment))
Approach
Find and replace, with some careful reading to distinguish some confusing cases:
get_connect()was called on a Connect object itself (it just returnedself!) rather than some API entityget_content()top-level function that retrieves all content records, vs. the$get_content()R6 method.Checklist
NEWS.md(referencing the connected issue if necessary)?devtools::document()?