Skip to content

Conversation

@nealrichardson
Copy link
Collaborator

Intent

Just access the R6 slots directly. Remove ambiguity about which pattern we want to use (#459 (comment))

Approach

Find and replace, with some careful reading to distinguish some confusing cases:

  • Where get_connect() was called on a Connect object itself (it just returned self!) rather than some API entity
  • Disambiguating the get_content() top-level function that retrieves all content records, vs. the $get_content() R6 method.

Checklist

  • Does this change update NEWS.md (referencing the connected issue if necessary)?
  • Does this change need documentation? Have you run devtools::document()?

@nealrichardson nealrichardson changed the title refactor: remove unnecessary get_connect() and get_content() R6 methods refactor: remove unnecessary get_connect(), get_content(), get_variant() R6 methods Oct 15, 2025
Copy link
Collaborator

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nealrichardson nealrichardson merged commit 9fd4116 into main Oct 15, 2025
21 checks passed
@nealrichardson nealrichardson deleted the remove-getters branch October 15, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants