feat: adds count method to resources #105
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
I'd delete this and just use tests/posit/connect/__api__/v1/users?page_number=1&page_size=2.json in the test
| responses.get( | ||
| "https://connect.example/__api__/v1/users", | ||
| json=load_mock("v1/users.json"), | ||
| ) |
There was a problem hiding this comment.
If you took the suggestion to only request page_size=1 above, add this here:
match=[
responses.matchers.query_param_matcher(
{"page_size": 1}
)
],
| @@ -148,3 +148,8 @@ def update(self) -> User: | |||
|
|
|||
| def delete(self) -> None: | |||
| raise NotImplementedError() | |||
|
|
|||
| def count(self) -> int: | |||
| response: requests.Response = self.session.get(self.url, json={"page_size": 1}) | |||
There was a problem hiding this comment.
For my own edification: is this type hint necessary? Doesn't it (waves hands) know that requests.Session.get() returns requests.Response? And that Response.json() returns dict?
There was a problem hiding this comment.
No, it isn't necessary. Once I added the correct type declaration to session in the __init__ method, this type declaration became redundant.
Your understanding is correct 😄
Resolves #47