From 9f4e0f91245eea18049aa3b6f8bf73b93a72a8da Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 10 Oct 2024 16:25:13 -0400 Subject: [PATCH] split commands into two --- .github/workflows/pytest.yaml | 5 +++-- Makefile | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml index d9ae2ece0..5da3226e2 100644 --- a/.github/workflows/pytest.yaml +++ b/.github/workflows/pytest.yaml @@ -252,8 +252,9 @@ jobs: - name: Setup py-shiny id: install uses: ./.github/py-shiny/setup - - name: Run test + - name: Run test commands env: UV_SYSTEM_PYTHON: 1 run: | - make test-narwhals-integration + make narwhals-install-shiny + make narwhals-test-integration diff --git a/Makefile b/Makefile index 028c66d3a..3988a088b 100644 --- a/Makefile +++ b/Makefile @@ -249,8 +249,9 @@ upgrade-html-deps: FORCE ## Upgrade Shiny's HTMLDependencies fi @scripts/htmlDependencies.R -test-narwhals-integration: FORCE +narwhals-install-shiny: FORCE @echo "-------- Install py-shiny ----------" $(MAKE) ci-install-deps +narwhals-test-integration: FORCE @echo "-------- Running py-shiny tests ----------" $(MAKE) test playwright TEST_FILE="tests/playwright/shiny/components/data_frame" PYTEST_BROWSERS="--browser chromium"