From 762c9d58fd5796190fc21eb9e3b9eae8a03a380a Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Mon, 3 Feb 2025 09:55:10 -0600 Subject: [PATCH 1/2] fix narwhals test --- tests/pytest/test_render_data_frame_tbl_data.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/pytest/test_render_data_frame_tbl_data.py b/tests/pytest/test_render_data_frame_tbl_data.py index 6b5b777fc..0279ea8ac 100644 --- a/tests/pytest/test_render_data_frame_tbl_data.py +++ b/tests/pytest/test_render_data_frame_tbl_data.py @@ -366,11 +366,15 @@ def test_dtype_coverage(): for dtype_name in dtype_names: # Skip known types or imports that are not dtypes + if dtype_name.endswith("Type"): + # "DType", + # "NestedType", + # "NumericType", + # "TemporalType", + # "TemporalType", + continue if dtype_name in ( # narwhals - "DType", - "NumericType", - "TemporalType", "Unknown", # typing import "Literal", From b6258b4dce262b898639ab1cde5514eeb5c0d369 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Mon, 3 Feb 2025 11:03:37 -0500 Subject: [PATCH 2/2] Update tests/pytest/test_render_data_frame_tbl_data.py --- tests/pytest/test_render_data_frame_tbl_data.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/pytest/test_render_data_frame_tbl_data.py b/tests/pytest/test_render_data_frame_tbl_data.py index 0279ea8ac..123e987b6 100644 --- a/tests/pytest/test_render_data_frame_tbl_data.py +++ b/tests/pytest/test_render_data_frame_tbl_data.py @@ -371,7 +371,6 @@ def test_dtype_coverage(): # "NestedType", # "NumericType", # "TemporalType", - # "TemporalType", continue if dtype_name in ( # narwhals