-
Notifications
You must be signed in to change notification settings - Fork 27
Description
While setting up my local environment following the contributing guide, I ran make fmt and noticed that some files were automatically formatted.
make fmt is ran beforemake lint in CI, so formatting issues are fixed before the linting catches them, but the format changes are not committed. Perhaps auto-formatting should not happen in CI so that formatting issues can be caught by make lint, which would require the PR author to run make fmt locally and push their changes to fix them. Open to other ideas to ensure formatting issues are caught in CI as well.
example of auto-formatting in CI: https://github.com/posit-dev/rsconnect-python/actions/runs/12395900176/job/34602689918#step:6:24
rsconnect-python/.github/workflows/main.yml
Lines 41 to 42 in d3b38cb
| - run: make fmt | |
| - run: make lint |
rsconnect-python/.github/workflows/main.yml
Lines 65 to 66 in d3b38cb
| - run: make fmt | |
| - run: make lint |