From 3aa8c380ef36af99b010967ae00f16c4a4a54dbf Mon Sep 17 00:00:00 2001 From: isabelizimm Date: Fri, 21 Oct 2022 16:26:00 -0400 Subject: [PATCH 1/3] change pip list to pip freeze --- rsconnect/environment.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rsconnect/environment.py b/rsconnect/environment.py index a2851b3b..5df5d5ca 100644 --- a/rsconnect/environment.py +++ b/rsconnect/environment.py @@ -218,7 +218,7 @@ def pip_freeze(): """ try: proc = subprocess.Popen( - [sys.executable, "-m", "pip", "list", "--format=freeze"], + [sys.executable, "-m", "pip", "freeze"], stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True, From 8bcbb65546a25b1546f8932ad41839dfa6653bc1 Mon Sep 17 00:00:00 2001 From: Bincheng Wu Date: Mon, 28 Nov 2022 08:34:31 -0500 Subject: [PATCH 2/3] update typing usage per flake8 --- rsconnect/environment.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/rsconnect/environment.py b/rsconnect/environment.py index 5df5d5ca..337bec89 100644 --- a/rsconnect/environment.py +++ b/rsconnect/environment.py @@ -43,15 +43,15 @@ def MakeEnvironment( - conda=None, # type: Optional[str] - contents="", # type: Optional[str] - error=None, # type: Optional[str] - filename="", # type: Optional[str] - locale="", # type: Optional[str] - package_manager="", # type: Optional[str] - pip=None, # type: Optional[str] - python=None, # type: Optional[str] - source=None, # type: Optional[str] + conda: Optional[str] = None, + contents: Optional[str] = None, + error: Optional[str] = None, + filename: Optional[str] = None, + locale: Optional[str] = None, + package_manager: Optional[str] = None, + pip: Optional[str] = None, + python: Optional[str] = None, + source: Optional[str] = None, ): return Environment(conda, contents, error, filename, locale, package_manager, pip, python, source) From 6e9b223fe5d758a1e046ea7f7272c0dd972602a4 Mon Sep 17 00:00:00 2001 From: Bincheng Wu Date: Mon, 28 Nov 2022 08:56:58 -0500 Subject: [PATCH 3/3] update changelog --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 986a2aa0..dbeba3e1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [Unreleased] + +### Changed + +Update pip_freeze to use `pip freeze` since Connect filters for valid package paths in the backend and it no longer depends on the undocumented behavior of `pip list --format=freeze`. This reverts the change made in 1.5.2. + ## [1.12.1] - 2022-11-07 ### Changed