Skip to content

Conversation

@tdstein
Copy link
Collaborator

@tdstein tdstein commented Jul 10, 2023

Intent

Changes the CONNECT_TASK_TIMEOUT to a reasonable default of 86,400 seconds (24 hours).

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Automated Tests

Automated tests have been updated to validate the timeout value.

Directions for Reviewers

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@tdstein tdstein marked this pull request as ready for review July 10, 2023 20:13
@tdstein tdstein self-assigned this Jul 10, 2023
@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4202 2667 63% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/timeouts.py 100% 🟢
TOTAL 100% 🟢

updated for commit: c6cc160 by action🐍

@tdstein tdstein requested review from aronatkins and mmarchetti July 10, 2023 20:15
@tdstein
Copy link
Collaborator Author

tdstein commented Jul 10, 2023

@aronatkins - @mmarchetti and I discussed and think 24 hours is a reasonable default timeout.

@tdstein tdstein merged commit 356c866 into master Jul 10, 2023
@tdstein tdstein deleted the tdstein/442 branch July 10, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants