Skip to content

Conversation

@tdstein
Copy link
Collaborator

@tdstein tdstein commented Jul 11, 2023

Intent

The existing error message does not provide any valuable feedback for users. This change adds detailed information so that the user has the opportunity to resolve the issue themselves.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Automated Tests

Directions for Reviewers

This change may be viewed by setting the CONNECT_TASK_TIMEOUT to 1 and executing a deployment.

For example,

CONNECT_TASK_TIMEOUT=1 rsconnect deploy api --server https://rsc.radixu.com/ --api-key <your-api-key> ./

An error should be thrown with the following message:

Error: The task timed out after 1 seconds.

You may try increasing the task timeout value using the CONNECT_TASK_TIMEOUT environment variable. The default value is 86400 seconds. The value is currently set to 1 seconds.

Example:

CONNECT_TASK_TIMEOUT=86400 rsconnect deploy api --server <your-server> --api-key <your-api-key> ./

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@tdstein tdstein self-assigned this Jul 11, 2023
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4205 2670 64% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/api.py 66% 🟢
rsconnect/timeouts.py 100% 🟢
TOTAL 83% 🟢

updated for commit: 577d164 by action🐍

@tdstein tdstein merged commit ef24a55 into master Jul 11, 2023
@tdstein tdstein deleted the tdstein/442 branch July 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants