refactor: upgrade some content and bundle APIs to v1 #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
approved these changes
Dec 1, 2025
Collaborator
tdstein
left a comment
tdstein
left a comment
There was a problem hiding this comment.
Seems good to me. I didn't test the backwards compatibility, but it looks fine.
|
|
||
| def content_upload_bundle(self, content_guid: str, tarball: typing.IO[bytes]) -> BundleMetadata: | ||
| response = cast( | ||
| Union[BundleMetadata, HTTPResponse], self.post("v1/content/%s/bundles" % content_guid, body=tarball) |
Collaborator
There was a problem hiding this comment.
nit; f-strings are preferred
Contributor
Author
There was a problem hiding this comment.
The other methods in RSConnectClient are doing this style of string interpolation too, I'll make a followup issue to update everything at once [edit: #733]
nealrichardson
force-pushed
the
migrate-some-v1-apis
branch
from
599a928 to
cd047fb
Compare
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Removes calls to 4 undocumented APIs and replaces them with their v1 counterparts:
POST applications/:id(both create and update)POST applications/:id/uploadPOST applications/:id/deploy(this was already replaced by a v1 version and was unused)The v1 APIs have all been around for a long time, so there are no Connect server version checks.
Type of Change
Refactor
Approach
Ask Claude to help me with the upload one, and then we pulled on the thread a little more to remove some swapping of numeric ids for GUIDs.
Automated Tests
Mocks were updated for this. I'll trigger the Connect integration tests separately, IDK that we have actual integration coverage within the repo.
Directions for Reviewers
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.