Skip to content

fix: Open external links in a new tab #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 6, 2025
Merged

fix: Open external links in a new tab #120

merged 22 commits into from
Sep 6, 2025

Conversation

@gadenbuie
Copy link
Collaborator

@gadenbuie gadenbuie commented Sep 5, 2025 •
edited
Loading

Fixes #11

pkgload::load_all("pkg-r")

output_markdown_stream(
  "foo",
  content = "Here's a link to [wikipedia](https://wikipedia.org)."
)

output_markdown_stream(
  "foo",
  content = "Here's a link to [wikipedia](https://wikipedia.org).",
  content_type = "semi-markdown"
)

@gadenbuie gadenbuie force-pushed the fix/11-links-in-chat branch from cca8f4a to a227602 Compare September 5, 2025 13:24
@gadenbuie gadenbuie force-pushed the fix/11-links-in-chat branch from a227602 to 0b3e7b0 Compare September 5, 2025 13:28
@gadenbuie gadenbuie requested a review from cpsievert September 5, 2025 13:28
@cpsievert
Copy link
Collaborator

Have you tested that this works? I can confirm the rel="noopener noreferrer" is getting added, but it appears the target="_blank" gets stripped out, probably by DOMpurify cure53/DOMPurify#317

@gadenbuie
Copy link
Collaborator Author

Have you tested that this works? I can confirm the rel="noopener noreferrer" is getting added, but it appears the target="_blank" gets stripped out, probably by DOMpurify cure53/DOMPurify#317

Oh shoot, yeah I saw the rel attribute was added and thought it was both. I'll fix the sanitization too

@gadenbuie
fix(js): Add external link attributes
71bb826 
Now a two step process:
* Markdown renderer adds `data-external-link` to external links
* DOMPurify adds `target="_blank" rel="noopener noreferrer"` to links with that attribute

Otherwise sanitization strips out the target attribute.
@gadenbuie
chore: build and update assets
86e7605
@gadenbuie
Copy link
Collaborator Author

@cpsievert okay, now it works! 😃

cpsievert
cpsievert reviewed Sep 5, 2025
View reviewed changes
@gadenbuie gadenbuie mentioned this pull request Sep 5, 2025
Open
cpsievert
cpsievert reviewed Sep 5, 2025
View reviewed changes
cpsievert
cpsievert reviewed Sep 5, 2025
View reviewed changes
cpsievert
cpsievert reviewed Sep 5, 2025
View reviewed changes
cpsievert
cpsievert reviewed Sep 5, 2025
View reviewed changes
cpsievert
cpsievert reviewed Sep 5, 2025
View reviewed changes
@gadenbuie gadenbuie merged commit e04f8bc into main Sep 6, 2025
16 checks passed
@gadenbuie gadenbuie deleted the fix/11-links-in-chat branch September 6, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Small suggestion - render links so that they open in a new tab

3 participants

@gadenbuie @cpsievert