Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the fontspec error about \newfontfamily #236

Open
wants to merge 1 commit into
base: master
from

Conversation

@jeongwhanchoi
Copy link

@jeongwhanchoi jeongwhanchoi commented Oct 9, 2018

Fix the fontspec error below; replace to \newfontfamily{\FA}{FontAwesome.otf}

screen shot 2018-10-09 at 2 52 04 pm

When compiling in local Tex (not Overleaf), this extension should be specified like this commit.

FloThinksPi added a commit to FloThinksPi-Forks/Awesome-CV that referenced this pull request Nov 11, 2018
Fixes Compilation Error when commenting out the \newfont: xdvipdfmx:fatal: pdf_ref_obj(): passed invalid object.
As well als the Compilation Error: LaTeX3 Error: Command '\FA' already defined!For immediate help type H <return>.

Fixes posquit0#221 by unsetting /FA before redefining it.

In Contrary to other Pull Reqests posquit0#233 posquit0#235 and posquit0#236 i found, fontawsome works with this change.
Tested with MikTex on Windows.
@@ -9,7 +9,7 @@
\usepackage{fontspec}

% Define shortcut to load the Font Awesome font.
\newfontfamily{\FA}{FontAwesome}
\newfontfamily{\FA}{FontAwesome.otf}

This comment has been minimized.

@thehamstermuffin

thehamstermuffin Sep 26, 2019

It seems to work, but I think this should be ttf to correspond to the font file

Suggested change
\newfontfamily{\FA}{FontAwesome.otf}
\newfontfamily{\FA}{FontAwesome.ttf}

This comment has been minimized.

@mbaralle

mbaralle Sep 27, 2019

Doesn't otf format have more features than ttf? Having that in mind, otf would be the best choice if we add the corresponding file

@@ -9,7 +9,7 @@
\usepackage{fontspec}

% Define shortcut to load the Font Awesome font.
\newfontfamily{\FA}{FontAwesome}
\newfontfamily{\FA}{FontAwesome.otf}

This comment has been minimized.

@mbaralle

mbaralle Sep 27, 2019

Doesn't otf format have more features than ttf? Having that in mind, otf would be the best choice if we add the corresponding file

Copy link

@thiagobfiorenza thiagobfiorenza left a comment

All right!

@crouther
Copy link

@crouther crouther commented Oct 18, 2019

if this problem is resolved should the request be close?

@saihaj
saihaj approved these changes Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants