Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message database default character set utf8mb4 #391

Open
wants to merge 3 commits into
base: master
from

Conversation

@phelset
Copy link
Contributor

phelset commented Oct 26, 2017

Resolves #390

@catphish

This comment has been minimized.

Copy link
Contributor

catphish commented Nov 1, 2017

This looks cool, I'll try to get it merged soon.

@phelset

This comment has been minimized.

Copy link
Contributor Author

phelset commented Jan 24, 2018

@catphish could you please test and review this?

@ilijastuden

This comment has been minimized.

Copy link

ilijastuden commented Feb 20, 2018

Please, please.

@rbustos

This comment has been minimized.

Copy link

rbustos commented May 15, 2018

@catphish Any chance to marge @phelset commits?

@rbustos

This comment has been minimized.

Copy link

rbustos commented May 17, 2018

Confirmed.
We tested these changes into our Postal and issues are gone.

@sg227

This comment has been minimized.

Copy link

sg227 commented Mar 12, 2019

Would it be possible to merge this @catphish? Emoji support is becoming more important by the day!

@mleader1

This comment has been minimized.

Copy link

mleader1 commented Mar 13, 2019

Hi there - it took me nearly a day to finally land on this solution - which worked perfectly. Can we have this merged please.....

@TheChef23

This comment has been minimized.

Copy link

TheChef23 commented Mar 14, 2019

Hi there - it took me nearly a day to finally land on this solution - which worked perfectly. Can we have this merged please.....

I'll second that, please merge this.

@JayMaree

This comment has been minimized.

Copy link

JayMaree commented Mar 28, 2019

@catphish please merge it. We need it.

@catphish

This comment has been minimized.

Copy link
Contributor

catphish commented Apr 8, 2019

Is there some reason why utf8mb4_bin is being used here rather than case insensitive?

@JayMaree

This comment has been minimized.

Copy link

JayMaree commented Apr 17, 2019

Is there some reason why utf8mb4_bin is being used here rather than case insensitive?

utf8mb4_bin works, right? Who can test it and merge it?

@rthenter1212

This comment has been minimized.

Copy link

rthenter1212 commented Aug 17, 2019

This really needs to be added. I deal with Asian chars and utf8 does not support all of them. I am missing incoming emails due to this issue.

@TheChef23

This comment has been minimized.

Copy link

TheChef23 commented Aug 29, 2019

I agree, this should be merged.

@willpower232

This comment has been minimized.

Copy link
Collaborator

willpower232 commented Dec 30, 2019

Is there some reason why utf8mb4_bin is being used here rather than case insensitive?

@phelset switching from ci to bin is likely to cause issues for some use cases, did you have a particular need for bin?

@catphish

This comment has been minimized.

Copy link
Contributor

catphish commented Dec 30, 2019

I'm actually inclined to agree that this should be _ci, but I'd have to check there's not a specific reason why _bin was chosen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

10 participants
You can’t perform that action at this time.