postal.getSubscribersFor updates

[ifandelse]

The current getSubscribersFor method can find all subscribers for a given channel and topic. However, it will only look for exact matches to a topic binding (so if you subscribed with "some.topic.#", but you call getSubscribersFor and pass "some.topic.goodness", then the subscription you created with the wildcard binding will NOT be returned in the results.

I'm proposing we change this so that the topic you pass to getSubscribersFor gets compared to the subscription definition topic bindings via the bindingsResolver.

What say you @dcneiner @arobson @nicholascloud @estaylorco?

[estaylorco]

@ifandelse I agree with leveraging the bindingsResolver. Any extension to postal should be, I think, internally consistent with the design of postal itself. This is particularly important to me since I use a custom bindingsResolver suggested to me in this forum to handle RESTful style topics instead of AMQP-style topics.

I think I would lose out if the bindingsResolver weren't leveraged (I had overlooked the impact of wildcard matching on the unsubscribeAllFor scenario).

[ifandelse]

Ok - this is in rc3 now: https://github.com/postaljs/postal.js/releases/tag/v0.9.0-rc3.

Warning - it does break the API of getSubscribersFor - it now takes either an options object or a predicate, just like unsubscribeFor.

[estaylorco]

@ifandelse I just downloaded rc3. I'll be playing with the bits this weekend. I don't believe I'm using getSubscribersFor, so I think I'll be fine there.

Thanks, again, for your hard work!