Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] grid-gap is depracated #1046

Closed
yepninja opened this issue May 16, 2018 · 6 comments
Labels

Comments

@yepninja
Copy link
Collaborator

@yepninja yepninja commented May 16, 2018

https://developer.mozilla.org/en-US/docs/Web/CSS/grid-gap
https://drafts.csswg.org/css-grid/#change-2016-grid-gap

grid-gap is already deprecated (renamed to gap). It's would be also good to handle gap property.

@ai

This comment has been minimized.

Copy link
Member

@ai ai commented May 16, 2018

Autoprefixer is only about prefixes. We can generate -ms- from gap, but not grid-gap.

@yepninja

This comment has been minimized.

Copy link
Collaborator Author

@yepninja yepninja commented May 16, 2018

It's not about adding prefixes to gap. It's about latest release (the feature of adding empty tracks when grid-gap and grid-template-areas detected). Now we handle only grid-gap.

@ai

This comment has been minimized.

Copy link
Member

@ai ai commented May 16, 2018

Yeap, we need to support gap in this case too.

@ai ai added the support label May 22, 2018
@yepninja yepninja added this to Inbox in Autoprefixer May 23, 2018
@yepninja yepninja moved this from Inbox to Need decision in Autoprefixer May 23, 2018
@yepninja yepninja moved this from Need decision to In progress in Autoprefixer May 31, 2018
@yepninja yepninja moved this from In progress to Waiting for release in Autoprefixer Jun 1, 2018
@ai

This comment has been minimized.

Copy link
Member

@ai ai commented Jun 1, 2018

Closed by #1054

@ai ai closed this Jun 1, 2018
Autoprefixer automation moved this from Waiting for release to Done Jun 1, 2018
@ai

This comment has been minimized.

Copy link
Member

@ai ai commented Jun 2, 2018

Released in 8.6 “Follow Reason”

@JLHwung

This comment has been minimized.

Copy link
Contributor

@JLHwung JLHwung commented Jun 8, 2018

Autoprefixer is only about prefixes. We can generate -ms- from gap, but not grid-gap.

FYI I just write a plugin that generates grid-gap from gap: https://github.com/JLHwung/postcss-gap-grid-prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Autoprefixer
  
Done
3 participants
You can’t perform that action at this time.