Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] grid-gap is depracated #1046

Closed
yepninja opened this issue May 16, 2018 · 11 comments
Closed

[css-grid] grid-gap is depracated #1046

yepninja opened this issue May 16, 2018 · 11 comments
Labels

Comments

@yepninja
Copy link
Collaborator

@yepninja yepninja commented May 16, 2018

https://developer.mozilla.org/en-US/docs/Web/CSS/grid-gap
https://drafts.csswg.org/css-grid/#change-2016-grid-gap

grid-gap is already deprecated (renamed to gap). It's would be also good to handle gap property.

@ai
Copy link
Member

@ai ai commented May 16, 2018

Autoprefixer is only about prefixes. We can generate -ms- from gap, but not grid-gap.

@yepninja
Copy link
Collaborator Author

@yepninja yepninja commented May 16, 2018

It's not about adding prefixes to gap. It's about latest release (the feature of adding empty tracks when grid-gap and grid-template-areas detected). Now we handle only grid-gap.

@ai
Copy link
Member

@ai ai commented May 16, 2018

Yeap, we need to support gap in this case too.

@ai
Copy link
Member

@ai ai commented Jun 1, 2018

Closed by #1054

@ai ai closed this Jun 1, 2018
@ai
Copy link
Member

@ai ai commented Jun 2, 2018

Released in 8.6 “Follow Reason”

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jun 8, 2018

Autoprefixer is only about prefixes. We can generate -ms- from gap, but not grid-gap.

FYI I just write a plugin that generates grid-gap from gap: https://github.com/JLHwung/postcss-gap-grid-prefix

@Dan503
Copy link
Contributor

@Dan503 Dan503 commented Dec 25, 2019

@ai found the old grid-gap deprecation issue.

The comments in this issue suggest that it has been fixed in v8.6 but when I tried on https://autoprefixer.github.io/ (v9.7.3) gap isn't getting prefixed with grid-gap

tailwindlabs/tailwindcss#1274 (comment)

@ai
Copy link
Member

@ai ai commented Dec 26, 2019

@Dan503 sorry, I have too many open-source tasks today. Can you help me? What is input CSS, what is current warnings and what is expected warnings?

@ai ai reopened this Dec 26, 2019
@yepninja
Copy link
Collaborator Author

@yepninja yepninja commented Dec 26, 2019

@Dan503 This issue is not about prefixing gap property with grid prefix. It's about support of gap property as grid-gap when calculating tracks for IE.

For example:

.example {
    display: grid;
    grid-template-columns: 1fr 1fr;
    gap: 10px;
}

transpiles to:

.example {
    display: -ms-grid;
    display: grid;
    -ms-grid-columns: 1fr 10px 1fr;
    grid-template-columns: 1fr 1fr;
    gap: 10px;
}

If you want to transpile gap to grid-gap, you should use postcss-gap-properties, which is a part of postcss-preset-env

@yepninja
Copy link
Collaborator Author

@yepninja yepninja commented Dec 26, 2019

@ai I think this issue can be closed again

@Dan503
Copy link
Contributor

@Dan503 Dan503 commented Dec 26, 2019

Oh ok, the bug title was misleading.

I'll open a new issue because I still think this should be built directly into Autoprefixer core rather than rely on third-party alternatives.

@yepninja yepninja closed this Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants