New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] grid-[column/row]: span X; can be translated safely #1065

Closed
Dan503 opened this Issue Jun 18, 2018 · 7 comments

Comments

3 participants
@Dan503
Copy link
Contributor

Dan503 commented Jun 18, 2018

input

.grid-cell {
  grid-column: span 6;
}

expected output

.grid-cell {
  -ms-grid-column-span: 6;
  grid-column: span 6;
}

current output: (and it warns you not to use this syntax)

.grid-cell {
  grid-column: span 6;
}
@ai

This comment has been minimized.

Copy link
Member

ai commented Jun 18, 2018

/cc @yepninja

@ai ai added this to Inbox in Autoprefixer Jun 18, 2018

@Dan503

This comment has been minimized.

Copy link
Contributor

Dan503 commented Jun 18, 2018

Note that Autoprefixer can handle this just fine

.grid-cell {
  grid-column-end: span 6;
}

it outputs this:

.grid-cell {
  -ms-grid-column-span: 6;
  grid-column-end: span 6;
}

@ai ai moved this from Inbox to Need code in Autoprefixer Jun 18, 2018

@ai ai added the enhancement label Jun 28, 2018

@Dan503 Dan503 changed the title grid-column: span X; can be translated safely [css-grid] grid-column: span X; can be translated safely Aug 2, 2018

@Dan503

This comment has been minimized.

Copy link
Contributor

Dan503 commented Aug 3, 2018

@bogdan0083 Thanks for all the awesome work you've been doing. :)

How do you feel about fixing this one?

I don't imagine it would be that difficult to fix.

@bogdan0083

This comment has been minimized.

Copy link
Contributor

bogdan0083 commented Aug 4, 2018

Thanks for all the awesome work you've been doing. :)

@Dan503 I'm happy to help :). Your reviews were extremely helpful, thank you for that too 😄

How do you feel about fixing this one?

It's not a big of a problem to fix this. I'll see what I can do 👍

@bogdan0083

This comment has been minimized.

Copy link
Contributor

bogdan0083 commented Aug 4, 2018

Fixed here: #1090

@Dan503

This comment has been minimized.

Copy link
Contributor

Dan503 commented Aug 4, 2018

I should have included this in the original issue

input

.grid-cell {
  grid-column: span 2;
  grid-row: span 2;
}

expected output

.grid-cell {
  -ms-grid-column-span: 2;
  grid-column: span 2;
  -ms-grid-row-span: 2;
  grid-row: span 2;
}

@Dan503 Dan503 changed the title [css-grid] grid-column: span X; can be translated safely [css-grid] grid-[column/row]: span X; can be translated safely Aug 4, 2018

@ai ai closed this in #1090 Aug 4, 2018

Autoprefixer automation moved this from Need code to Done Aug 4, 2018

@ai

This comment has been minimized.

Copy link
Member

ai commented Aug 13, 2018

Released in 9.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment