Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Show warning if grid-area and grid-(row/column) both present in the same rule #1125

Merged

Conversation

@bogdan0083
Copy link
Contributor

@bogdan0083 bogdan0083 commented Sep 21, 2018

Fixes #1122

cc @Dan503

Should we change warning message or we'll leave it like this?

@bogdan0083 bogdan0083 force-pushed the bogdan0083:feature/grid-area-grid-row-column-warning branch from 49afd6b to 96aed45 Sep 21, 2018
@Dan503

This comment has been minimized.

Copy link
Contributor

@Dan503 Dan503 commented on lib/hacks/grid-utils.js in 2e3c5e3 Sep 21, 2018

I'm happy with the error message. It just needs an "a" so it says.

"You already have a grid-area declaration present..."

@ai ai merged commit 557560f into postcss:master Sep 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.